-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N3 parsing of local names with special characters #523
base: main
Are you sure you want to change the base?
N3 parsing of local names with special characters #523
Conversation
Thanks for your contribution. I cannot say much about it contentwise and leave that up to @timbl . From a quality perspective it is good to see more tests passing. I did not know rdflib-evaluation before. Could we include it in github actions? Nevertheless the code changes a lot and I would like to see this covered by unit tests as well. Those tests would also serve as a documentation of the changes so that it is easier to grasp how the code actually behaves. |
@@ -168,7 +168,7 @@ $Id: n3parser.js 14561 2008-02-23 06:37:26Z kennyluck $ | |||
|
|||
HAND EDITED FOR CONVERSION TO JAVASCRIPT | |||
|
|||
This module implements a Nptation3 parser, and the final | |||
This module implements a Notation3 parser, and the final | |||
part of a notation3 serializer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
part of a notation3 serializer. | |
part of a Notation3 serializer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I cannot say much about it contentwise and leave that up to @timbl .
From a quality perspective it is good to see more tests passing. I did not know rdflib-evaluation before. Could we include it in github actions? Nevertheless the code changes a lot and I would like to see this covered by unit tests as well. Those tests would also serve as a documentation of the changes so that it is easier to grasp how the code actually behaves.
Hello,
the goal of this commit is to improve the handling of local names with special characters. I modified the implementation of the "qname" function in accordance to https://github.com/RDFLib/rdflib/blob/master/rdflib/plugins/parsers/notation3.py (function "qname").
Also to align with https://github.com/RDFLib/rdflib/blob/master/rdflib/plugins/parsers/notation3.py:
I tested the modification with rdflib-evaluation. No regression and tests succeeding are up from 193 to 211 (out of 298). (Tests attached to this pull request).
Best regards,
Arnaud
spec-rdflib-ntriples-patch.txt
spec-rdflib-ntriples-reference.txt
spec-rdflib-turtle-patch.txt
spec-rdflib-turtle-reference.txt