-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeouts - change default timeout in fetcher from 30s to 2min #454
base: main
Are you sure you want to change the base?
Conversation
Responds to #455 |
Hm, is this for one single http roundtrip? |
The user can easily override the timeout setting if needed. Erring on the long side seems preferable to too short a timeout. I suppose that the timeout could be overwritten in the global solidFetcher to reset the timeout everywhere for apps that create multiple fetchers? |
Hm, but what about my comment in #455 (comment) / https://gitter.im/solid/solidcommunity.net?at=5fa54c68c10273610aeca65a ? |
"One single http round trip" isn't of course a singe IP round trip, as it can have all the TLS setup time, and CORS prefetches... it also can be delayed by the browser by being put in a pending state for a while. So when all this happens n a slow link, it is frustrating when the data actually eventually arrives but the client has given up and ignored it. |
Yes, agreed that the fetch with the server should be set shorter ... maybe the thing to do is to cover the whole service of one incoming request, not each individual outgoing one. Would be good to to tell the client in the 500 response what it was doing when it gave up of course. |
…duleResolution: node in tsconfig
This is to avoid spurious timeouts called on things which in the end come though, when the net becomes slow for example, or for users on a slow link.