Allow falsy targets to be passed to the serializer #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating rdflib from
0.12.x
to0.17.x
in solid-permissions, I noticed that a bunch of unit tests in solid-permissions fail with the following error:This crash occurs because the
serialize.js
assumes thattarget
is defined, while solid-permissions sometimes passesnull
. Not sure who is at fault here, but in this PR I assume that rdflib should accept falsytarget
values.With this change, all unit tests from solid-permissions pass on rdflib 0.17.x.