Removed dependency to global $rdf #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@megemege77 - Great catch on the usage of the |
| @@ -37,6 +37,7 @@ const parseRDFaDOM = require('./rdfaparser').parseRDFaDOM | |||
| const RDFParser = require('./rdfxmlparser') | |||
| const Uri = require('./uri') | |||
| const Util = require('./util') | |||
| const serialize = require('./serialize') | |||
There was a problem hiding this comment.
I assume you're adding const serialize = require('./serialize') to fetcher.js because you want to fix the usage of $rdf.serialize on line 590?
Do you mind adding that fix to this PR?
(Also, while you're in fetcher.js, can you also fix the global usage of $rdf.Util on line 867?)
|
Dear Dmitri Thanks for the constructive feedback, I'm glad you like the idea of removing the reference to the global. I reworked it to really remove all references, as you suggested, but did it in one comit in a new PR, see linked PR #161. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including rdflib.js into a web application using webpack, the
resulting application doesn't run. The reason for this is that there are
references to the global $rdf object in modules which are initialized
before the global $rdf object has been properly initialized.
Removed all references to the global $rdf object and
replaced them by direct references to the underlying functionality.