Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core,message-utils): support date,time format with short/default/long/full and skeleton #2117

Merged
merged 1 commit into from
Dec 27, 2024
Merged

feat(core,message-utils): support date,time format with short/default/long/full and skeleton #2117

merged 1 commit into from
Dec 27, 2024

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Dec 10, 2024 •
edited
Loading

Description

Adding support for short/default/long/fullfull compatible with a reference implementation from here:

https://messageformat.github.io/messageformat/guide/#date-and-time

Only date and time are supported for now.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #2116

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Dec 23, 2024 8:49am

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 3.22 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@timofei-iatsenko timofei-iatsenko changed the title feat(core,message-utils): support date format feat(core,message-utils): support date,time format with short/default/long/full and skeleton Dec 10, 2024
@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review December 10, 2024 13:49
@timofei-iatsenko timofei-iatsenko mentioned this pull request Dec 10, 2024
Closed
@timofei-iatsenko timofei-iatsenko mentioned this pull request Dec 16, 2024
Merged
@auroursa auroursa mentioned this pull request Dec 20, 2024
Draft
@andrii-bodnar andrii-bodnar merged commit 8020427 into main Dec 27, 2024
7 of 9 checks passed
@andrii-bodnar andrii-bodnar deleted the feat/support-date-format branch December 27, 2024 12:39
@andrii-bodnar
Copy link
Contributor

@timofei-iatsenko the integration testing fails because of @messageformat/date-skeleton

PTAL: https://github.com/lingui/js-lingui/actions/runs/12516245974/job/34915134361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support different date format for locales
2 participants
@timofei-iatsenko @andrii-bodnar