Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0KB文件不会下载 #789

Closed
xuanu opened this issue Oct 11, 2017 · 4 comments · Fixed by #944
Closed

0KB文件不会下载 #789

xuanu opened this issue Oct 11, 2017 · 4 comments · Fixed by #944
Labels
bug
Milestone
1.7.2

Comments

@xuanu
Copy link

xuanu commented Oct 11, 2017

文件大小：0kb
文件名：.nomedia
错误提示：java.net.MalformedURLException: Protocol not found：xxx
@SelenaWong
Copy link

遇到相同的问题，0字节的文件，下载时直接报错：status = -1

@rantianhua
Copy link
Collaborator

rantianhua commented Feb 2, 2018 •
edited
Loading

0 字节的文件，目前是直接当做异常抛出。感谢指正，这里应该当做下载完成而不是抛一个异常，这个会在 1.7.1 版本中修复。

@rantianhua rantianhua added the bug label Feb 2, 2018
@rantianhua rantianhua added this to the 1.7.1 milestone Feb 2, 2018
@rantianhua
Copy link
Collaborator

@xuanu 根据你的错误提示，是你的链接没有指定协议造成的，详情可以参考这里

@rantianhua
Copy link
Collaborator

@SelenaWong 希望能提供下具体的错误日志。

@rantianhua rantianhua modified the milestones: 1.7.1, 1.7.2 Feb 5, 2018
rantianhua pushed a commit to rantianhua/FileDownloader that referenced this issue Feb 5, 2018
fix: don't download empty file
2395da4 
complete directly if the file size is zero
close lingochamp#789
@rantianhua rantianhua mentioned this issue Feb 5, 2018
Merged
Jacksgong added a commit that referenced this issue Feb 8, 2018
@Jacksgong
Merge pull request #944 from rantianhua/master
7e5fde1 
fix: fix can't download empty file
close #789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.7.2
Development

Successfully merging a pull request may close this issue.

fix: don't download empty file rantianhua/FileDownloader
3 participants
@rantianhua @xuanu @SelenaWong