Use heterogeneous lists in code generated by Witty derive macros #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The code generated by Witty derive macros is non-trivial and is mostly equivalent to the implementation for
frunk
's heterogeneous lists.Proposal
Refactor the Witty derive macros to generate code that use heterogeneous lists instead of code to manually handle each field in a type. This reduces the amount of code generated, centralizes the more complex code in the implementations for
frunk
types and hopefully improves readability of the generated code.Test Plan
The unit and integration tests that already exist cover the behavior which the refactoring must not change.
Links
This is an unexpected extra work related to of #906.
Release Plan
Reviewer Checklist