Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistence in responses of endpoints for specific date and for dates range when start date is weekend #71

Open
sergey-koryshev opened this issue Nov 10, 2024 · 4 comments

Comments

@sergey-koryshev
Copy link

There is some inconsistence in responses of the following endpoints, for example:

  1. https://api.frankfurter.app/2024-11-03
  2. https://api.frankfurter.app/2024-11-03..2024-11-04

The first one returns rates for 2024-11-01 which is last work day before 2024-11-03 and this is right data to work with. But second endpoint returns rates only for 2024-11-04 and data for 2024-11-01 is absent. Using rates from 2024-11-01 to exchange prices for date 2024-11-03 is more correctly than using rates from 2024-11-04.

@sergey-koryshev sergey-koryshev changed the title Inconsistence in responses of endpoints for specific date and for date range when start date is weekend Inconsistence in responses of endpoints for specific date and for dates range when start date is weekend Nov 10, 2024
@Rolv-Apneseth
Copy link
Contributor

To add on to this - https://api.frankfurter.app/2024-11-02..2024-11-03 will just return an error

@hakanensari
Copy link
Member

Noted, I’ll look at both shortly and get back with an update. Thanks!

@sergey-koryshev
Copy link
Author

The other interesting case is when start time/end time is Monday and it's today actually. If there is no exchange rate for this date yet, we need to get it from last Friday, but the request will return not found error in response. It reproduces on Mondays, for example: https://api.frankfurter.app/2024-11-16..2024-11-18

@hakanensari
Copy link
Member

This endpoint should now work as expected, thanks for all the input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants