Port to linebender/parley#170 #755
Conversation
I've had to add a hack to workaround a (new)? Parley bug where an empty initial text causes a crash Note that later setting the text to be empty does not reproduce the crash
There was a problem hiding this comment.
FYI @dfrg it seems like something has changed with line height? Is this expected.
There was a problem hiding this comment.
I didn’t change individual line height but updated the overall layout dimensions to use the max_coord of each line so that the layout box encompasses the full text. There’s obviously something funky going on with how line metrics are calculated because these should be the same but the web compatible line height changes added some complex interactions and I haven’t had time to investigate that.
There was a problem hiding this comment.
Hmm. I've just done some quick testing, and descenders still seem to be cut off when clipping to the layout box. See also https://xi.zulipchat.com/#narrow/channel/205635-text/topic/Some.20funny.20typography.20with.20Masonry
The descenders being cut off is:
I've had to add a hack to workaround a (new)? Parley bug where an empty initial text causes a crash Note that later setting the text to be empty does not reproduce the crash
There are also some privacy workarounds which I've needed to do and have reported upstream.