Import our intended set of lints #432
Conversation
Co-authored-by: Olivier FAURE <[email protected]>
DJMcNab
force-pushed
the
lints-glorious-lints
branch
from
ea88aa1 to
4759177
Compare
| rust.unused_macro_rules = "warn" | ||
| rust.variant_size_differences = "warn" | ||
|
|
||
| clippy.allow_attributes_without_reason = "warn" |
There was a problem hiding this comment.
Hmm this, pollutes my diagnostics in my editor, without being able to action about it, since this does seem to be experimental, and thus CI fails when adding a reason (as seen here) , should we disable that for now, and enable it, when it's stable, maybe with directly fixing all of this, so that it doesn't contribute to OCD^^?
There was a problem hiding this comment.
We can comment this out.
However, the behaviour you're seeing is confusing - since rust-lang/rust-clippy#12999, this shouldn't be happening for you, because it checks the MSRV to see whether to suggest this lint
There was a problem hiding this comment.
Hmm that's interesting (just updated nightly, and still the issue).
I don't use rust via rustup, but via rust-overlay maybe that's an issue, as there's no rustup-binary on my system. I mean it's not critical to me, I can just comment it out locally.
Discovered in #432; this would otherwise cause errors for users of nightly (or 1.81 beta, due to be released next week)
Increases the MSRV to allow setting lints in `Cargo.toml`. This imports the same set of lints as in linebender/xilem#432
See discussion in #linebender > Standard Lint set
Of note: I have taken steps to ensure that this can be practically reviewed by not applying most of the lints.
The commented out lints make good follow-ups