Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to MSRV 1.82 in preparation for color #745

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Update to MSRV 1.82 in preparation for color #745

merged 10 commits into from
Nov 27, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Nov 27, 2024

No description provided.

waywardmonkeys
waywardmonkeys reviewed Nov 27, 2024
View reviewed changes
vello/src/recording.rs Outdated Show resolved Hide resolved
vello/src/debug/renderer.rs Outdated Show resolved Hide resolved
waywardmonkeys
waywardmonkeys reviewed Nov 27, 2024
View reviewed changes
vello_encoding/src/lib.rs
@@ -32,6 +32,8 @@
#![allow(
unnameable_types,
clippy::shadow_unrelated,
// Only applies on WASM?
variant_size_differences,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more likely that it is 32 bit targets, not just wasm, like I ran into in Peniko. But some 32 bit targets can't do AtomicU64, and so we don't support building on them all.

xStrom
xStrom reviewed Nov 27, 2024
View reviewed changes
vello/src/lib.rs Outdated Show resolved Hide resolved
vello_encoding/src/lib.rs Outdated Show resolved Hide resolved
vello_shaders/src/lib.rs Outdated Show resolved Hide resolved
vello/src/lib.rs Outdated Show resolved Hide resolved
xStrom
xStrom reviewed Nov 27, 2024
View reviewed changes
vello/src/util.rs Outdated Show resolved Hide resolved
xStrom
xStrom approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good work! 🚀

@DJMcNab DJMcNab added this pull request to the merge queue Nov 27, 2024
Merged via the queue into linebender:main with commit e6ead09 Nov 27, 2024
17 checks passed
@DJMcNab DJMcNab deleted the msrv-1.82 branch November 27, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys left review comments

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DJMcNab @waywardmonkeys @xStrom