Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to wgpu 23.0.0 #735

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Update to wgpu 23.0.0 #735

merged 3 commits into from
Nov 22, 2024

Conversation

waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Nov 6, 2024 •
edited
Loading

This also updates the MSRV to 1.76 to match the updated MSRV of wgpu 23.

@waywardmonkeys waywardmonkeys marked this pull request as draft November 6, 2024 16:26
@waywardmonkeys
Copy link
Contributor Author

This is just a draft for now since it gets to be PR #735 and the update to 22 was #635. Still need to get wgpu-profiler fixed and a new release made.

DJMcNab
DJMcNab approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barring wgpu-profiler, this looks correct.

Nice that our MSRV checks are working as designed

vello/src/wgpu_engine.rs Outdated Show resolved Hide resolved
@waywardmonkeys
Copy link
Contributor Author

@DJMcNab This is now failing on macOS only in the many_bins_gpu test that you added as part of #680 / #681. Confirmed that it happens locally on this branch and not on current main.

Thoughts or pointers?

@DJMcNab
Copy link
Member

DJMcNab commented Nov 11, 2024

That is extraordinarily bizarre; it seems to have fixed #680, but only on macOS? That doesn't make sense.

I don't really know how to begin debugging this, as I don't have a Mac.
One thing to try is reproducing #680 in an actual window - i.e make a window larger than your screen using the "drag down, expand/resize up" trick.

That test is effectively a reverse regression test, i.e. that if we fix the mentioned issue, we should also close #680.
I'd be reasonably happy to just ignore the test on macOS and move on...

@xStrom xStrom mentioned this pull request Nov 18, 2024
Closed
@waywardmonkeys waywardmonkeys marked this pull request as ready for review November 22, 2024 15:18
@waywardmonkeys waywardmonkeys added this pull request to the merge queue Nov 22, 2024
@waywardmonkeys waywardmonkeys removed this pull request from the merge queue due to a manual request Nov 22, 2024
@waywardmonkeys waywardmonkeys added this pull request to the merge queue Nov 22, 2024
@waywardmonkeys waywardmonkeys added this to the Vello 0.4 Release milestone Nov 22, 2024
Merged via the queue into linebender:main with commit 2f2eaa5 Nov 22, 2024
17 checks passed
@waywardmonkeys waywardmonkeys deleted the update-to-wgpu-23 branch November 22, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Vello 0.4 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @DJMcNab