Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deeper blend stacks by spilling to a buffer #657

Merged
merged 10 commits into from
Aug 6, 2024
Merged

Allow deeper blend stacks by spilling to a buffer #657

merged 10 commits into from
Aug 6, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Aug 6, 2024

This brings in support for blend spilling (which was supported in the old piet-gpu).

I don't have a good heuristic for how big to make the buffer. That is something which will need to be addressed in #606 (or its successors). I just guessed that 256 spills would be fine. I think this is probably too small - I suspect we'll get feedback from @TrueDoctor about this.

I have confirmed that the robustness works as expected with the GPU shaders.

@DJMcNab DJMcNab requested a review from raphlinus August 6, 2024 11:20
raphlinus
raphlinus approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. We'll do some followup work with the robust dynamic memory.

@DJMcNab DJMcNab added this pull request to the merge queue Aug 6, 2024
Merged via the queue into linebender:main with commit c7b615e Aug 6, 2024
17 checks passed
@DJMcNab DJMcNab deleted the blend-stack branch August 6, 2024 15:42
@DJMcNab DJMcNab mentioned this pull request Aug 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2024
@DJMcNab
Free the blend_spill buffer (#661)
59c0fa5 
This was missed in #657

I have been running into consistent issues with freeing things
incorrectly; I think we need to develop better tools for this.

This will be a consideration for the planned API changes.
@waywardmonkeys waywardmonkeys added this to the Vello 0.3 release milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Vello 0.3 release
Development

Successfully merging this pull request may close these issues.
3 participants
@DJMcNab @raphlinus @waywardmonkeys