[pico_svg] Encode group transform in scene #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build the scene recursively, applying the transform at group nodes, rather than flattening to a single list of items. This causes the transform to be applied correctly to stroke styles, which among other things fixes the rendering of the waves example from the Nehab timings data set. We're deliberately keeping things minimal, but if we were to add other properties to groups (clips, opacity, etc), then this change would support that.
DJMcNab
approved these changes
Jun 11, 2024
| @@ -71,6 +71,38 @@ fn example_scene_of(file: PathBuf) -> ExampleScene { | |||
| } | |||
| } | |||
|
|
|||
| fn render_svg_rec(items: &[crate::pico_svg::Item]) -> Scene { | |||
There was a problem hiding this comment.
I don't really like this function name; I'm not familiar with this _rec naming scheme being used.
Unfortunately, I don't have a better suggestion at the moment, so it's probably fine to keep?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the scene recursively, applying the transform at group nodes, rather than flattening to a single list of items. This causes the transform to be applied correctly to stroke styles, which among other things fixes the rendering of the waves example from the Nehab timings data set.
We're deliberately keeping things minimal, but if we were to add other properties to groups (clips, opacity, etc), then this change would support that.