Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wasm): GpuProfilerSettings not initialized on startup #497

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix(wasm): GpuProfilerSettings not initialized on startup #497

merged 1 commit into from
Mar 4, 2024

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Mar 4, 2024

Closes #494

@simbleau simbleau requested a review from DJMcNab March 4, 2024 19:08
DJMcNab
DJMcNab approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I think it would be worth tracking down the actual issue as well, but I don't think it's that useful to track it in our issue tracker, as, whilst we support the web, we don't necessarily support the profiling

@simbleau simbleau added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit af72e66 Mar 4, 2024
9 checks passed
@xStrom xStrom deleted the issue-494 branch March 5, 2024 00:17
@xStrom xStrom mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web Demo hangs after a minute
2 participants
@simbleau @DJMcNab