-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copyright header check to CI. #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question.
Well this worked just fine on my local Ubuntu install, but the GitHub Action runner seems to print out |
Explicitly setting the search path helped solved that issue. I also tested that the CI properly notices invalid headers with some bogus commits that I later reverted. This is now ready. |
Since #456 was merged we have standardized copyright headers here. This PR adds a check to the CI to ensure that we keep them nice and consistent.
The script also has two things to quickly support a more complex future.
This has been used for example in Peniko as the Peniko Authors and the Piet Authors.
Worth noting that the ripgrep command itself is cross-platform. However the bash script obviously isn't. However at this point that isn't a big deal, because we don't need to check the headers on every platform. So we just piggyback on the
rustfmt
Ubuntu job.