Full pipeline running in browser #220
Conversation
|
|
||
| // On wasm, append the canvas to the document body | ||
| let canvas = window.canvas(); | ||
| canvas.set_width(1044); |
There was a problem hiding this comment.
I see this size is pre-existing, so I don't think we need to change it, but 1044 is not a very round number
There was a problem hiding this comment.
This was specifically not very round to test an output that didn't align to a tile boundary.
piet-wgsl/examples/winit/src/main.rs
Outdated
| run_wasm(event_loop, window).await | ||
| } | ||
|
|
||
| async fn run_wasm(event_loop: EventLoop<()>, window: Window) { |
There was a problem hiding this comment.
This function name isn't quite right. I'd be tempted here to factor out the wasm specific code from main into the equivalent place in run, and then not create the second function.
AFAIK, resizable just does nothing on web, rather than causing issues.
There was a problem hiding this comment.
Refactored this a bit: run_wasm -> run and the native code is simply pulled into main
| @@ -1,5 +1,5 @@ | |||
| [package] | |||
| name = "winit" | |||
| name = "winit-demo" | |||
There was a problem hiding this comment.
Ha, I've been meaning to fix this. I presume you ran into the issue where it couldn't work out which winit you meant in cargo run -p winit?
|
This works on Canary Chrome (but is still missing some strokes). I'm comfortable with it going in based on the review it's gotten, but can also take a closer look if people feel that's needed. |
|
I feel pretty good about it as is. Feel free to merge |
| [workspace.package] | ||
| edition = "2021" | ||
| version = "0.1.0" | ||
| authors = ["piet-gpu developers"] |
There was a problem hiding this comment.
I think current best practise is to just not set authors
The default cargo new excludes it. I'm not too bothered either way it shakes out
| // On wasm, append the canvas to the document body | ||
| let canvas = window.canvas(); | ||
| canvas.set_width(1044); | ||
| canvas.set_height(800); |
There was a problem hiding this comment.
I'm slightly surprised this is needed; does setting the window size when creating it from winit not work?
I don't think it matters that much though
This is based on #201 and probably supersedes it. It's still hacky but does demonstrate the full pipeline running in a browser.
This is the command line I use:
Then navigate Chrome Canary (with WebGPU flag enabled) to http://localhost:8000/
Fails on Windows because FXC, but runs on mac M1.
Significant progress toward #202