Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vello_shaders causes recompilation #569

Closed
waywardmonkeys opened this issue May 6, 2024 · 1 comment · Fixed by #570
Closed

vello_shaders causes recompilation #569

waywardmonkeys opened this issue May 6, 2024 · 1 comment · Fixed by #570
Milestone
Vello 0.2 release

Comments

@waywardmonkeys
Copy link
Collaborator

Now that we use vello_shaders, it causes rebuilds on every run of cargo build / cargo run / etc.

This is due to crates/shaders/build.rs unconditionally writing out the new shader file:

std::fs::write(dest_path, &buf).unwrap();

This needs to only write it if it has changed.

cc: @armansito
@waywardmonkeys waywardmonkeys added this to the Vello 0.2 release milestone May 7, 2024
@waywardmonkeys
Copy link
Collaborator Author

The issue is much easier than that. PR coming momentarily.

waywardmonkeys added a commit to waywardmonkeys/vello that referenced this issue May 7, 2024
@waywardmonkeys
shaders: Fix dependency on shader directory.
e4912ca 
The dependency on the `shader` directory was incorrect (wrong
path), so cargo was rebuilding this library on every invocation
of `cargo build`.

Also moved it earlier just to separate it out from the code that
did the build and writing of the generated `shaders.rs` file.

Fixes linebender#569.
@waywardmonkeys waywardmonkeys mentioned this issue May 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 7, 2024
@waywardmonkeys
shaders: Fix dependency on shader directory. (#570)
9aee6c8 
The dependency on the `shader` directory was incorrect (wrong path), so
cargo was rebuilding this library on every invocation of `cargo build`.

Also moved it earlier just to separate it out from the code that did the
build and writing of the generated `shaders.rs` file.

Fixes #569.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Vello 0.2 release
Development

Successfully merging a pull request may close this issue.

shaders: Fix dependency on shader directory. waywardmonkeys/vello
1 participant
@waywardmonkeys