Skip to content

Commit

Permalink
Fixup too-many-arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
DJMcNab committed Nov 27, 2024
1 parent a79604e commit bf5f4be
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 29 deletions.
2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ rust.unused_macro_rules = "warn"
rust.unused_qualifications = "warn"
rust.variant_size_differences = "warn"

clippy.too_many_arguments = "allow"

clippy.allow_attributes = "warn"
clippy.allow_attributes_without_reason = "warn"
clippy.cast_possible_truncation = "warn"
Expand Down
4 changes: 0 additions & 4 deletions examples/scenes/src/simple_text.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ impl SimpleText {
///
/// Note that Vello does support COLR emoji, but does not currently support
/// any other forms of emoji.
#[allow(clippy::too_many_arguments)]
pub fn add_colr_emoji_run<'a>(
&mut self,
scene: &mut Scene,
Expand Down Expand Up @@ -75,7 +74,6 @@ impl SimpleText {
/// not significantly increasing repository size.
///
/// This will use a CBTF font, which Vello supports.
#[allow(clippy::too_many_arguments)]
pub fn add_bitmap_emoji_run<'a>(
&mut self,
scene: &mut Scene,
Expand All @@ -100,7 +98,6 @@ impl SimpleText {
);
}

#[allow(clippy::too_many_arguments)]
pub fn add_run<'a>(
&mut self,
scene: &mut Scene,
Expand All @@ -125,7 +122,6 @@ impl SimpleText {
);
}

#[allow(clippy::too_many_arguments)]
pub fn add_var_run<'a>(
&mut self,
scene: &mut Scene,
Expand Down
4 changes: 0 additions & 4 deletions examples/scenes/src/test_scenes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -882,10 +882,6 @@ mod impls {
params.resolution = Some((1200.0, 1200.0).into());
}

#[expect(
clippy::too_many_arguments,
reason = "This function is internal, so the argument count doesn't cause issues for consumers."
)]
pub(super) fn two_point_radial(scene: &mut Scene, _params: &mut SceneParams) {
pub(super) fn make(
scene: &mut Scene,
Expand Down
4 changes: 0 additions & 4 deletions examples/with_winit/src/stats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ pub struct Snapshot {
}

impl Snapshot {
#[expect(
clippy::too_many_arguments,
reason = "This function is internal, so the argument count doesn't cause issues for consumers."
)]
pub fn draw_layer<'a, T>(
&self,
scene: &mut Scene,
Expand Down
4 changes: 0 additions & 4 deletions vello/src/debug/renderer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,6 @@ impl DebugRenderer {
}
}

#[expect(
clippy::too_many_arguments,
reason = "This function is internal, so the argument count doesn't cause issues for consumers."
)]
pub fn render(
&self,
recording: &mut Recording,
Expand Down
8 changes: 0 additions & 8 deletions vello/src/wgpu_engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,6 @@ impl WgpuEngine {
})
}

#[expect(
clippy::too_many_arguments,
reason = "This function is internal, so the argument count doesn't cause issues for consumers."
)]
pub fn add_render_shader(
&mut self,
device: &Device,
Expand Down Expand Up @@ -1056,10 +1052,6 @@ impl<'a> TransientBindMap<'a> {
.expect("texture not materialized")
}

#[expect(
clippy::too_many_arguments,
reason = "This function is internal, so the argument count doesn't cause issues for consumers."
)]
fn create_bind_group(
&mut self,
bind_map: &mut BindMap,
Expand Down
5 changes: 0 additions & 5 deletions vello_shaders/src/cpu.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@
//! a full CPU fallback as an alternative to GPU shaders is not provided.
// Allow un-idiomatic Rust to more closely match shaders
#![expect(
clippy::needless_range_loop,
clippy::too_many_arguments,
reason = "Keeps code easily comparable to GPU shaders"
)]

mod backdrop;
mod bbox_clear;
Expand Down

0 comments on commit bf5f4be

Please sign in to comment.