Add support for markers in-between fills/strokes #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazrFalcon
reviewed
Nov 5, 2023
|
Good question. I guess I didn't wanted to duplicated paths or thought that stroke outlining would be required, but it should be fine now. |
|
Yeah I mean the path duplication only happens for that specific case, so I guess it is worth to clone it just in this case so that the output is correct. ^^ |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #550.
Although you do mention in the issue that it's not possible to implement this without adding markers in usvg itself, so I'm not sure if I'm missing something obvious? 😅 But at least the test cases work as expected.