Fix CoreGraphics copy_raw_pixels swaping red and blue channels. #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#196 added stride support which is great, but the pixel byte order swapping introduced there seems wrong.
SCALE
intest-picture.rs
to something else like1.0
causes the output test image to have blue and red swapped. Confirming the bug.Thus I have modified the code to keep the pixel component order as is, even when the stride is partially used.
I have manually tested this change to work correctly by temporarily removing the fast path and always using the new code.