Add x/y extend modes and quality hint to images #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `Image` to support separate extend modes for each dimension. Also adds an `ImageQuality` enum to allow the user to specify a hint for rendering. I choose low/medium/high variants rather than specific filters so that we're not making a specific commitment to any set. Finally, renames `Format` to `ImageFormat` for consistency.
waywardmonkeys
approved these changes
Dec 12, 2024
DJMcNab
reviewed
Dec 12, 2024
| pub enum ImageQuality { | ||
| /// Lowest quality with best performance characteristics. | ||
| /// | ||
| /// This is typically nearest neighbor sampling. |
There was a problem hiding this comment.
I'd quite like to see NearestNeighbour available as an explicit option, because for certain applications it is something you want to force.
waywardmonkeys
added a commit
to waywardmonkeys/peniko
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Imageto support separate extend modes for each dimension.Also adds an
ImageQualityenum to allow the user to specify a hint for rendering. I choose low/medium/high variants rather than specific filters so that we're not making a specific commitment to any set.Finally, renames
FormattoImageFormatfor consistency.