-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fontique] use windows-rs for dwrite backend #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have my Windows machine handy, so I can't actually run this, so just going through the patch when DirectWrite isn't my thing, so I have a couple of questions below.
The code looks better overall though!
@dfrg Any chance this could land soon so that it can be part of our next release? |
Alright, I'll take a look at this and rebase/merge if it looks good. |
2aa7d7c
to
8f4efc0
Compare
Swaps out winapi, wio and dwrote for windows-core and windows.
8f4efc0
to
a54676c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with 2 comments (1 of which requires action).
f7db2a5
to
3ffe71f
Compare
Swaps out winapi, wio and dwrote for windows-core and windows.