fontique: Make icu_properties optional
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Jun 3, 2024
|
+1, thanks. I’m also fine with making this off by default and enabling the feature in parley if necessary. |
|
I'm going to wait and see if @dfrg thinks we should just remove it from the default features since I'm not in a rush. |
|
@dfrg |
This isn't enabled by default as it isn't needed within `parley`.
waywardmonkeys
force-pushed
the
make-icu_properties-optional
branch
from
3bdf1fb to
52f4269
Compare
|
Removing from default sounds good to me. |
|
Updated with it removed from default features. |
dfrg
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem like everyone using
fontiquewill need this (or already have it in their dependency graph).I left this in
defaultsince that's the current behavior, but I think there's a good case for not doing so.