Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to multi-crate layout. #59

Merged
merged 1 commit into from
May 23, 2024
Merged

Migrate to multi-crate layout. #59

merged 1 commit into from
May 23, 2024

Conversation

waywardmonkeys
Copy link
Contributor

This moves all parley items into a subdirectory next to fontique.

@waywardmonkeys
Copy link
Contributor Author

This lacks a top level README.md as it seems like maybe there isn't a general template yet for this for Linebender repos.

@nicoburns I'd assumed that maybe examples would / could still live at the top level. Maybe I'm wrong!

DJMcNab
DJMcNab reviewed May 23, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but we need a top-level README, even if it's just a stub.

The pattern to follow in this repository is probably Android Trace, i.e. list out the crates directly

parley/Cargo.toml Show resolved Hide resolved
parley/LICENSE-APACHE Outdated Show resolved Hide resolved
parley/LICENSE-APACHE Outdated Show resolved Hide resolved
@xStrom
Copy link
Member

xStrom commented May 23, 2024

Yeah the top-level readme template isn't finalized. That said, I think it's fine to just keep a copy of the old top-level readme and update it separately from this PR.

@waywardmonkeys
Copy link
Contributor Author

Okay, I've rebased on top now that the tiny-skia sample landed.

I'll fix the clippy thing with a separate PR and then rebase again.

@waywardmonkeys
Copy link
Contributor Author

Yeah the top-level readme template isn't finalized. That said, I think it's fine to just keep a copy of the old top-level readme and update it separately from this PR.

For now, I did this and hopefully we can follow up quickly (a day or so?) with a better top level README.

nicoburns
nicoburns approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this as-is now there's a README. That will need updating, but it will be easier to do that work in parallel with other work if this one is merged.

Compile errors (see clippy check failures) will of course need addressing.

@waywardmonkeys
Copy link
Contributor Author

Hmm, guess I have to modify CI now ...

@waywardmonkeys
Migrate to multi-crate layout.
e8ae259 
This moves all `parley` items into a subdirectory next to
`fontique`.
@waywardmonkeys
Copy link
Contributor Author

Okay, I think I got the CI this time. I'd made the example use a workspace dependency on parley (that I added), but that didn't have default features enabled while the old build did. So now the example still uses that workspace dependency, but enables default-features.

@waywardmonkeys
Copy link
Contributor Author

@nicoburns @DJMcNab If you could re-approve with that revision, that'd be great! And then I'll merge it!

@DJMcNab
Copy link
Member

DJMcNab commented May 23, 2024

Looks like #63 might also fix this. @xStrom which should we land first?

@waywardmonkeys
Copy link
Contributor Author

Looks like #63 might also fix this. @xStrom which should we land first?

That's fixing a separate issue ... my problem in this one with CI was just my own brain damage, corrected now. :)

@waywardmonkeys waywardmonkeys added this pull request to the merge queue May 23, 2024
Merged via the queue into linebender:main with commit 49e055a May 23, 2024
19 checks passed
@waywardmonkeys waywardmonkeys deleted the multi-crate-layout branch May 23, 2024 14:09
xStrom added a commit to xStrom/parley that referenced this pull request May 23, 2024
@xStrom
Revert "Migrate to multi-crate layout. (linebender#59)"
c14ee22 
This reverts commit 49e055a.

Revert "Add automatic CI support for packages without the `std` feature. (linebender#63)"

This reverts commit eb2c68a.

Revert "tiny_skia_render: Fix unused qualifications. (linebender#62)"

This reverts commit f7f339b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@dfrg dfrg Awaiting requested review from dfrg

@xStrom xStrom Awaiting requested review from xStrom

@nicoburns nicoburns Awaiting requested review from nicoburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waywardmonkeys @xStrom @DJMcNab @nicoburns