Add way to get coefficients from Affine #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `as_coeffs` method to Affine so we can get the coefficients out (necessary for conversion to Direct2D types, etc). Also tweak documentation to explain the convention for rotation (partially addressing #4) and the augmented matrix representation of Affine, particularly that it's backwards from PostScript. This doesn't address all of #4, it doesn't change any behavior.
|
Ping @Connicpu for sanity-check regarding matrices. In particular, does the mint conversion (ColumnMatrix2x3) still make sense? |
It tried to interpret the matrix in Affine::new as code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
as_coeffsmethod to Affine so we can get the coefficients out(necessary for conversion to Direct2D types, etc).
Also tweak documentation to explain the convention for rotation
(partially addressing #4) and the augmented matrix representation of
Affine, particularly that it's backwards from PostScript.
This doesn't address all of #4, it doesn't change any behavior.