Rationalize sign conventions #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document sign conventions in Shape. Add tests to confirm this is indeed the behavior. Fix broken cases. Some doc touchup. Fixes #4
cmyr
approved these changes
Jul 22, 2019
|
Anticlockwise -> counterclockwise? I never heard the former. Might be just me. |
|
... I'm trying to come up with some joke about RTL clocks but it's falling flat 😒 |
|
Just be thankful I didn't say "widdershins." But I can change it to "counter" if there's a consensus it's clearer. |
It's a matter of time... |
|
I like “anticlockwise” better than “counterclockwise”. I believe the former is more common in British than American English. But both are commonly used all over the place. But also +1 for switching to “sunwise” and “widdershins” 😝 Or how about “dextrogyre” and “lævogyre”? |
|
It hurts me that the companion to 'dextrogyre' isn't 'sinistegyre'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document sign conventions in Shape. Add tests to confirm this is
indeed the behavior. Fix broken cases. Some doc touchup.
Fixes #4