Add Linebender lint set v2. #402
Conversation
|
|
||
| #[cfg(not(any(feature = "std", feature = "libm")))] | ||
| compile_error!("kurbo requires either the `std` or `libm` feature"); | ||
|
|
||
| // Suppress the unused_crate_dependencies lint when both std and libm are specified. | ||
| #[cfg(all(feature = "std", feature = "libm"))] |
There was a problem hiding this comment.
but this shouldn't happen?
There was a problem hiding this comment.
If by this you mean:
- both
stdandlibmtogether -- well, it easily can, e.g. by using--all-features libmbeing unused when thelibmfeature is specified -- well,stdoverrides it so it won't be used
There was a problem hiding this comment.
But the case of --all-features will be a compile error because of the lines directly above this?
There was a problem hiding this comment.
I'm not trying to be difficult, just want to understand and I'm kind of dumb at the moment.
There was a problem hiding this comment.
No it won't be a compiler error. Our custom compiler error will trigger only when neither std nor libm is specified. At least one of those needs to be set. You can achieve that error with just --no-default-features.
There was a problem hiding this comment.
I am so brain dead right now. Going to sleep in shame and infamy.
Actually satisfying a good chunk of these lints is deferred and they are in an
allowblock inlib.rs.Still, I did satisfy some of the lints.
The
randmethodgenhas to be a rawr#genuntil they publish a new version. They have that method renamed inmaster.