Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog #373

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys waywardmonkeys mentioned this pull request Aug 30, 2024
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I've scanned through the changes, and this looks like everything which should be mentioned in the changelog.
The only change I'd like to see is:

## Unreleased

(line 14)
being changed to:

## [Unreleased](https://github.com/linebender/kurbo/compare/v0.11.0...HEAD)

I'm also not completely sure about how we want our "fixed" section to read; whether there's an implied "fixed ...". The current format saying "fix" in each item is more compatible with something like "Bug Fixes". (similarly "New Features" instead of "Added")

That is not to be dealt with in this PR.

@waywardmonkeys
Copy link
Contributor Author

It should've just been [Unreleased] since there was already a link for it below. Fixed.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Sep 2, 2024
Merged via the queue into linebender:main with commit f753199 Sep 2, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the update-changelog branch September 2, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants