Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test harness crashing on failure. #984

Merged
merged 1 commit into from
May 26, 2020
Merged

Fix test harness crashing on failure. #984

merged 1 commit into from
May 26, 2020

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented May 24, 2020

The piet context needs to be finished even if a test case fails. This PR achieves that via implementing Drop for Harness.

Fixes #950.

@xStrom xStrom added the S-needs-review waits for review label May 24, 2020
@luleyleo luleyleo mentioned this pull request May 24, 2020
Closed
cmyr
cmyr approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, I'm happy. 👍

@xStrom xStrom removed the S-needs-review waits for review label May 26, 2020
@xStrom xStrom merged commit f8197e4 into linebender:master May 26, 2020
@xStrom xStrom deleted the win-tests-fix branch May 26, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double panic in test harness
2 participants
@xStrom @cmyr