Add im::Vector support to the List widget. #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xStrom
added
widget
luleyleo
approved these changes
May 15, 2020
druid/src/widget/list.rs
Outdated
| } | ||
|
|
||
| #[cfg(feature = "im")] | ||
| impl<T1: Data, T: Data> ListIter<(T1, T)> for (T1, Vector<T>) { |
There was a problem hiding this comment.
Maybe call them Shared and T instead? Or at least S and T.
I still do not understand why people like useless names for generic parameters,
this is really not something where we should let mathematicians inspire us. 😉
There was a problem hiding this comment.
I just copied that from the Arc<Vec> implementation, but yeah it took me a while to grasp what the T1 even is, because I hadn't used List before. I changed it to S and added a comment.
There was a problem hiding this comment.
Thanks! At first I got it the wrong way, thought T1 would be the iterable due to the 1.
|
Something to reiterate: the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
im::Vectorsupport for theListwidget when theimfeature is enabled. It seems to work real nicely withListIter<T>where we can just pass references. The shared dataListIter<(T1, T)>implementation is less nice as we still need to clone data due to the signature. It may be worth looking into changing the signature for shared data lists in the future so that we could use just references even with shared data.The
Vectorusage seems much more ergonomical thanArc<Vec>. I also updated thelistexample to useVector. The real functional diff to the example looks great, with basically just removing code. However due to having to add feature guards the code diff looks a lot noisier.I also removed an unnecessary variable from the
Arc<Vec>implementation, which was the remnant of a previous refactoring.This PR also reverts the
Dataimplementation ofVec<T: Data>as discussed in #911. The implementation was broken as well.