Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLOSE and SHOW _WINDOW commands to utilize Target. #928

Merged
merged 2 commits into from
May 15, 2020
Merged

Update CLOSE and SHOW _WINDOW commands to utilize Target. #928

merged 2 commits into from
May 15, 2020

Conversation

luleyleo
Copy link
Collaborator

This is the first part of my PR for typed selectors (#908).

Now the CLOSE_WINDOW and SHOW_WINDOW commands both use the Target instead of passing the WindowId as payload.

@luleyleo luleyleo added the S-needs-review waits for review label May 14, 2020
xStrom
xStrom approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@luleyleo luleyleo added the breaking change pull request breaks user code label May 15, 2020
@luleyleo luleyleo merged commit 1f56a17 into linebender:master May 15, 2020
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
breaking change pull request breaks user code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luleyleo @xStrom