Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix menu updates in the multiwin example. #926

Merged
merged 13 commits into from
May 27, 2020
Merged

Fix menu updates in the multiwin example. #926

merged 13 commits into from
May 27, 2020

Conversation

kindlychung
Copy link
Contributor

No description provided.

@xStrom xStrom added the S-needs-review waits for review label May 14, 2020
jneem
jneem reviewed May 15, 2020
View reviewed changes
Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides fixing the CI failures, I just had some minor comments.

druid/examples/multiwin.rs Outdated Show resolved Hide resolved
druid/examples/multiwin.rs Outdated Show resolved Hide resolved
druid/examples/multiwin.rs Outdated Show resolved Hide resolved
@xStrom xStrom added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels May 16, 2020
@xStrom
Copy link
Member

xStrom commented May 16, 2020

This needs a rebase with master as the multiwin example has changed.

@kindlychung
Copy link
Contributor Author

@xStrom plz have another look.

@xStrom xStrom linked an issue May 24, 2020 that may be closed by this pull request
ui inconsistency in multiwin example #728
Closed
xStrom
xStrom reviewed May 24, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Please also add an entry to CHANGELOG.md - more instructions here. Put your entry under the Docs section where other example notes are.

@xStrom xStrom changed the title fix #728 Fix menu updates in the multiwin example. May 24, 2020
@xStrom xStrom added the examples concerns examples label May 24, 2020
@kindlychung
Copy link
Contributor Author

Done.

@xStrom
Copy link
Member

xStrom commented May 27, 2020 •
edited
Loading

You should also add the link definition for the PR number to CHANGELOG.md at the bottom where all the others are.

Move the entry to the Docs section, as this doesn't belong in Changed which is more so for API changes.

Also rebase with master to get CI to pass.

@kindlychung
Copy link
Contributor Author

Done.

xStrom
xStrom approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xStrom xStrom removed the S-waiting-on-author waits for changes from the submitter label May 27, 2020
@xStrom xStrom merged commit c4f92c1 into linebender:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneem jneem jneem left review comments

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
examples concerns examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui inconsistency in multiwin example
3 participants
@kindlychung @xStrom @jneem