-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor X11 Application to make use of the new structure. #894
Conversation
I also refactored Partial invalidation is also really broken on There's still an issue that the still-valid areas get cleared during partial repaint. I'll see if I can fix it quickly, but otherwise I think that would be fine for a new PR too. |
I ended up fixing partial invalidation too. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The X11 backend works A LOT better with this, thanks!
The inline comments aside I've found two issues:
- Closing one window in the
multiwin
example closes all windows - Somtimes widgets disappear, for example hovering over a button in the list example makes the label next to it disappear, or in
game_of_life
the slider / buttons at the bottom vanish when hovering another one.
I added more logging and cleanup of The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good now, thanks 👍
#763 introduced a new instance based
Application
structure. This PR refactors the X11Application
code to make use of it, as well as adding better error reporting.The
windows
map has reentrancy issues. Those were already there and this PR makes no attempt at solving them. I just merely refactored it to the newApplication
style.