Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GTK Application to make use of the new structure. #892

Merged
merged 3 commits into from
May 6, 2020

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Apr 30, 2020

#763 introduced a new instance based Application structure. This PR refactors the GTK Application code to make use of it, as well as adding better error reporting and removing duplicate thread assertions.

@xStrom xStrom added S-needs-review waits for review shell/gtk concerns the GTK backend labels Apr 30, 2020
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xStrom xStrom merged commit e2b4804 into linebender:master May 6, 2020
@xStrom xStrom deleted the application-linux branch May 6, 2020 11:26
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell/gtk concerns the GTK backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants