Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UpdateCtx::submit_command #855

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Add UpdateCtx::submit_command #855

merged 1 commit into from
Apr 17, 2020

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Apr 16, 2020

That this was missing was an oversight, and I now need it in runebender.

@cmyr
Add UpdateCtx::submit_command
a832a91 
That this was missing was an oversight.
@cmyr cmyr added the S-needs-review waits for review label Apr 16, 2020
luleyleo
luleyleo approved these changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍

xStrom
xStrom approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xStrom xStrom removed the S-needs-review waits for review label Apr 16, 2020
@cmyr cmyr merged commit 1384e6c into master Apr 17, 2020
@cmyr cmyr deleted the update-submit-command branch April 17, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luleyleo luleyleo luleyleo approved these changes

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmyr @xStrom @luleyleo