Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clippy checks for examples and tests. #850

Merged
merged 4 commits into from
Apr 16, 2020
Merged

Add clippy checks for examples and tests. #850

merged 4 commits into from
Apr 16, 2020

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Apr 15, 2020

The current CI configuration wasn't checking examples and tests for clippy mistakes.

@xStrom xStrom marked this pull request as ready for review April 16, 2020 00:06
@xStrom xStrom added the S-needs-review waits for review label Apr 16, 2020
luleyleo
luleyleo requested changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having clippy pass is certainly a nice upgrade!

druid-derive/Cargo.toml Outdated Show resolved Hide resolved
druid/Cargo.toml Outdated Show resolved Hide resolved
@xStrom
Copy link
Member Author

xStrom commented Apr 16, 2020

I reduce the dependency graph!

luleyleo
luleyleo approved these changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xStrom xStrom merged commit cb96b75 into linebender:master Apr 16, 2020
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luleyleo luleyleo luleyleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xStrom @luleyleo