Add new example for blocking functions #840
Conversation
There was a problem hiding this comment.
This is a wonderful example and I'm going to refer to it a lot. I took this code and with a few modifications made a file hasher.
My only complaint is the length of the example name. For some reason I don't have autocomplete when typing cargo run --example tktk. Maybe just call it blocking_function.rs?
| }); | ||
| } | ||
|
|
||
| impl AppDelegate<AppState> for Delegate { |
There was a problem hiding this comment.
I was wrapping my whole app in a Controller, this is a way better solution!
|
Sounds good, I've renamed it to blocking_function.rs. |
|
just a heads up I'd like to take a look at this before it goes in. :) |
| let either = Either::new(|data, _env| data.processing, button_placeholder, button); | ||
|
|
||
| Flex::column().with_child(label).with_child(either) | ||
| } |
There was a problem hiding this comment.
one problem with this example is that it isn't actually clear that we aren't blocking when we're doing the background work. I might try and make it slightly more complicated, maybe so that there are two counters, and we can increment the other one while the background task is happening? Or even just drawing some sort of progress indicator?
There was a problem hiding this comment.
I'm reluctant to add more complexity to this example, because I think there's a lot of value in making sure it's easily adaptable and easily understood, even to people new to druid.
I also think because of the nature of this example, proving that it's non-blocking isn't too necessary. When I had a blocking function freeze up my window on my project, I immediately had a look in examples to see if there was a pattern for dealing with that situation. I haven't tested it on linux or macos, but at least on windows it's very hard to miss when the UX thread is blocking - it locks up, the UX around it fades, and it'll offer to terminate it for you.
That said, if you think it's important to have two bits of UX running at the same time, I think a progress indicator makes the most sense.
|
@cmyr, not sure if you've seen my comment? |
|
Looks like you're going to need to explicitly ignore this example in |
|
This PR needs to be rebased with |
|
Thanks @mastfissh! |
It's not super obvious how to offload processing to other threads. If you run heavy processing on the UI thread, the experience is quite bad - you get a "not responding" prompt on windows, and things stop updating. To make it easier for others to do this, I've added this as an example.