Add "handled" state to event #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow an event to be handled, blocking further propagation.
cmyr
approved these changes
Jul 10, 2019
|
|
||
| /// Set the event as "handled", which stops its propagation to other | ||
| /// widgets. | ||
| pub fn set_handled(&mut self) { |
There was a problem hiding this comment.
There's an asymmetry here between set_handled and set_active. I prefer this to not take an argument, but maybe set_active doesn't need to either?
There was a problem hiding this comment.
No, set_active can definitely take false, for example on mouse-up in a button. I don't think it makes any sense to unset handled. Open to ideas of improving naming/docs tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an event to be handled, blocking further propagation.