Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown in Windows #2087

Merged
merged 6 commits into from
Dec 28, 2021
Merged

Dropdown in Windows #2087

merged 6 commits into from
Dec 28, 2021

Conversation

sjoshid
Copy link
Contributor

@sjoshid sjoshid commented Dec 13, 2021

I managed to successfully F up PR #2042. (Patting my back)

This PR adds ability to let dropdowns cross their parent boundary.

SubWindow

Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one very minor suggestion.

@sjoshid
Copy link
Contributor Author

sjoshid commented Dec 16, 2021

I need to fix the changes I made in set_position().
Please hold off on merging this.

* Removing `WindowHandle::set_level` as per issue linebender#1824
@sjoshid
Copy link
Contributor Author

sjoshid commented Dec 27, 2021

^^
This is ready to merge (assuming there are no more code review changes)

druid-shell/src/backend/windows/window.rs Outdated Show resolved Hide resolved
druid-shell/src/backend/windows/window.rs Outdated Show resolved Hide resolved
druid-shell/src/backend/windows/window.rs Outdated Show resolved Hide resolved
druid-shell/src/backend/windows/window.rs Outdated Show resolved Hide resolved
druid-shell/src/backend/windows/window.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jneem jneem merged commit 004c6eb into linebender:master Dec 28, 2021
@sjoshid sjoshid deleted the Fixes_2042 branch December 29, 2021 00:14
@sjoshid
Copy link
Contributor Author

sjoshid commented Dec 29, 2021

^ Thank you too.
Im going to pick your brain one last time.
Recently installed linux to understand more about gtk because it always comes up but Im seeing.........bizarre behavior to say the least.
My assumption was subwindow positioning was impl recently in gtk meaning it was working.
Is the assumption wrong?

gtk_issue.mp4
DragIssueGtk.mp4

@maan2003
Copy link
Collaborator

@sjoshid can you check the x11 backend (cargo run --example subwindow --features x11 --no-default-features)

@jneem
Copy link
Collaborator

jneem commented Dec 29, 2021

Thanks, I'll look into those. It's highly likely that some things didn't get properly updated when we changed to relative positions.

@sjoshid
Copy link
Contributor Author

sjoshid commented Dec 29, 2021

@maan2003 I cant. :( Im running into build errors one after another. Sorry.

@jneem Thanks.

@sjoshid
Copy link
Contributor Author

sjoshid commented Dec 30, 2021

I know Im late....but I fixed build errors (like libclang not found, etc.) for x11.
Happy to report x11 is working as expected (to Windows). The tooltip position is off in sub_window example but other than that it looks good.

@maan2003
Copy link
Collaborator

nice :). please create an issue about tooltip positioning with the desktop enviroment version, screenshots, ... I tried fixing positioning but it is hard to fix for all enviroments on linux.

@sjoshid
Copy link
Contributor Author

sjoshid commented Dec 30, 2021

Done. #2100

@jneem
Copy link
Collaborator

jneem commented Dec 30, 2021

@maan2003 I think I found a little bug with DP scaling and get_position (#2101).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants