Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the ListIter implementation for Vector #1967

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Fix the ListIter implementation for Vector #1967

merged 4 commits into from
Sep 13, 2021

Conversation

xarvic
Copy link
Collaborator

@xarvic xarvic commented Sep 12, 2021 •
edited
Loading

This PR fixes the ListIter implementation for Vector and makes the implementation for Arc<Vec<...>> more efficient.

The old implementation used iter_mut() on Vector which makes a deep copy of the Vector, therefore Data::same returned always false

Christoph and others added 3 commits September 12, 2021 20:56
@xarvic xarvic linked an issue Sep 12, 2021 that may be closed by this pull request
Infinite loop when using a Vector in a Subwindow #1966
Closed
maan2003
maan2003 approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes sense

@xarvic xarvic merged commit c93a7c4 into linebender:master Sep 13, 2021
@xarvic xarvic deleted the fix_list branch September 13, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maan2003 maan2003 maan2003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop when using a Vector in a Subwindow
2 participants
@xarvic @maan2003