X11 shell keyboard mapping #1779
Conversation
|
Nice to see so much progress on x11! My main concern at this point is the dependence on I wonder how much work it is just to run |
|
I feel same. Maintaining a |
|
Ready for review :) |
druid-shell/src/platform/x11/xkb.rs
Outdated
| /// | ||
| /// Reference counted under the hood. | ||
| // Assume this isn't threadsafe unless proved otherwise. (e.g. don't implement Send/Sync) | ||
| // TODO do we need UnsafeCell? |
There was a problem hiding this comment.
What would we need to check to find out? Is it a question of whether the FFI calls modify anything through the pointer?
There was a problem hiding this comment.
uh took code from wayland backend and missed this TODO 😬 . I will look into it
There was a problem hiding this comment.
I am not sure, why we need it; we only interact with *mut xkb_context
cc @derekdreery
There was a problem hiding this comment.
I've honestly forgot about how I did this with wayland, sorry!
There was a problem hiding this comment.
I don't think we need UnsafeCell, UnsafeCell is used to get *mut T from &T(well &UnsafeCell<T>) but already have *mut T
There was a problem hiding this comment.
thought about this again, I have no doubts.
I will merge in 2 days if no one objects.
|
Anything I can do to push this forward? |
|
still no consensus on if |
UnsafeCell is used to provide `*mut T` through `&T` but we already have `*mut T`
Resolves #1633
I am using a fork of theNow just running bindgenxcbcommon-syscrate because it doesn't build with x11 feature enabled, waiting for meh/rust-xkbcommon-sys#5 to merged.The xkb.rs is from #1498