X11 shell locale detection #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on gettext manual
maan2003
added
S-needs-review
jneem
reviewed
May 3, 2021
| // the value is priority list seperated by : | ||
| // See: https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html#The-LANGUAGE-variable | ||
| .and_then(|locale| locale.split(':').next().map(String::from)) | ||
| .unwrap_or_else(|| "en-US".to_string()) |
There was a problem hiding this comment.
Is there a difference between "en-US" and "en_US"? My system uses the latter...
There was a problem hiding this comment.
I think it is better idea to en_US. I used en-US because it was used in the stub earlier.
There was a problem hiding this comment.
The identifiers can vary in case and in the separator characters. The "-" and "_" separators are treated as equivalent, although "-" is preferred.
(from Unicode TR #35)
SecondFlight
approved these changes
May 4, 2021
SecondFlight
added
S-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on gettext manual.
Also on Linux, there is a priority list of locales rather than a single locale. Not sure if
Application::get_localeshould return a priority list.Fixes: #938