Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book: Fix the intro tutorial #1732

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Book: Fix the intro tutorial #1732

merged 2 commits into from
Apr 22, 2021

Conversation

SecondFlight
Copy link
Collaborator

The examples are written against Druid@latest, and this patch clarifies that and fixes the incorrect import code.

See also #1698.

This commit updates the druid version needed for the example to work, and rewrites a paragraph that was based on old code.
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SecondFlight SecondFlight added S-needs-review waits for review S-ready PR is ready to merge and removed S-needs-review waits for review labels Apr 22, 2021
@SecondFlight SecondFlight merged commit caff1b5 into master Apr 22, 2021
@SecondFlight SecondFlight deleted the book-fixes branch April 22, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants