-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DisabledIf widget #1702
DisabledIf widget #1702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few little notes and doc fixups, but nothing major!
Signed-off-by: xarvic <[email protected]>
Signed-off-by: xarvic <[email protected]>
Signed-off-by: xarvic <[email protected]>
Signed-off-by: xarvic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@xarvic I've invited you as a collaborator on this repo; you should feel free to merge your own PRs when they're approved and you're happy with them, and feel free to approve other PRs when you feel confident about the changes. :) |
Thanks :) How can I accept? I have not received an e-mail or a notification on Github |
So I'm playing around with |
Same here. I'm on Windows 10 with the latest Druid@master. |
I suspect that's because we need to land #1717, which implements the style changes. |
Works with #1717 👍 |
Sorry for my git-ignorance, but I'm pulling in: Since it looks like #1717 has been merged, do I just have to |
|
Aha! That did it. Thanks! :) |
Adds a widget wrapper that disables the inner widget if the provided closure returns true.
For the moment the only effect is that the text boxes annotated with "(disabled)" can't be focused by pressing Tab. The visual changes and changes in behavior are implemented on the widgets themselves in a following PR.