Support individual corner radii for kurbo::RoundedRect #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecondFlight
changed the title
|
@SecondFlight this should now be mergeable? |
|
Yeah, I just need to fix merge conflicts and do a smoke test. |
|
Did I accidentally float these changes into Druid in another PR?? The change set no longer includes the changes needed for this PR, but the code works and so I think the changes are somehow already on master. |
|
Ah nevermind, they were added here which makes total sense. I'll mark this ready for review, but there's not much to review; the only thing left relating to the rounded rect change is the updated changelog. I made a |
cmyr
approved these changes
Mar 31, 2021
richard-uk1
pushed a commit
to richard-uk1/druid
that referenced
this pull request
Apr 6, 2021
* Ignore all /target/ folders * Update Data impl for RoundedRect * Just ignore all folders matching **/target, which matches Piet's gitignore * Bump kurbo version to 0.8.0 * Update CHANGELOG.md Co-authored-by: Joshua Wade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on kurbo#166 and piet#391. This PR should not be merged until the upstream crates are updated and this PR is pointed to them. The changes in Kurbo are (mostly) backwards-compatible, so very little needs to change in Druid to incorporate the upstream changes.