adding added controller widget

[arthmis]

I had an issue with the documentation display. I followed the Click widget as an example, but I don't think the documentation is showing up as expected. Also there seems to be extra ' in the Click widget documentation. Is there anything I missed in the implementation?

EDIT (Richard Dodd) Closes #1480.

[jneem]

Looks good! I had some minor nitpicks with the docs.

[jneem]

Splitting hairs, maybe, but a Controller isn't a widget (the ControllerHost is).

[arthmis]

I think I was following the Click widget example. I don't remember if that's a full widget or a Controller type. So most of the docs I've written is paraphrasing Click's docs. I was trying to be consistent with that.

[arthmis]

I don't know what would be preferred here. I'm leaving it as is. I think calling it a Controller widget is appropriate. Anything else might be too verbose. I guess you can just call it controller like, "Create a new controller to respond to widget added to tree event".

[jneem]

Looks good to me! Unfortunately, clippy broke the build again and we can't merge until its fixed. I'll try to get to it later today if no one beats me to it.

[richard-uk1]

I've fixed up clippy for the rust 1.49 in #1461. If you rebase on that after it's merged, the clippy warning should go away. :)

Update You can rebase now to get the clippy fixes. If you need any help rebasing ping me; I'm happy to help. 😄

[arthmis]

Hi, I see the label waiting on author. Is there something I'm supposed to do?

[jneem]

You'll need to rebase your branch onto the master branch, to pull in the fixes for the broken CI.

[arthmis]

Uhh did I rebase correctly?

[richard-uk1]

Rebasing is fiddly! I will check out the PR and fix it up when I get chance.

[cmyr]

it looks like something went a bit wrong and you brought in a bunch of old commits. I would just do git fetch origin and git merge origin/master and then we can clean it up here, when we merge. :)

[arthmis]

Am i doing this from the current state?

Edit: Ok that should be right, now!

[cmyr]

Just skimming this again: I have a few little doc tweaks, but I also have one larger question, which is whether or not we should also be passing in the widget itself to the closure, as like &mut W? I think this probably makes sense.

[richard-uk1]

@cmyr are we OK to merge now, and shall we squash? @arthmis thanks very much for going through the motions with this PR 😄

[cmyr]

Yep squash sounds good :)