Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clipbox bug. #1448

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Fix clipbox bug. #1448

merged 2 commits into from
Dec 7, 2020

Conversation

richard-uk1
Copy link
Collaborator

@richard-uk1 richard-uk1 commented Dec 7, 2020 •
edited
Loading

ClipBox should recurse events if any of its children are active, not just its immediate child.

Closes #1436

@richard-uk1
Fix clipbox bug.
0fa9bdb 
ClipBox should recurse events if any of its children are active, not
just its immediate child.
@richard-uk1 richard-uk1 requested a review from cmyr December 7, 2020 21:06
cmyr
cmyr approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thanks!

@richard-uk1 richard-uk1 merged commit 6f3c076 into linebender:master Dec 7, 2020
@richard-uk1 richard-uk1 deleted the clipbox_has_active branch December 7, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Old radio button stays selected when new button is selected in RadioGroup.
2 participants
@richard-uk1 @cmyr