Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing call to CloseClipboard on windows #1410

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Add missing call to CloseClipboard on windows #1410

merged 3 commits into from
Nov 19, 2020

Conversation

andrewhickman
Copy link
Contributor

This could cause a druid application to steal control of the clipboard, preventing it from working in other apps

@andrewhickman andrewhickman changed the title Add missing call to CloseClipboard Add missing call to CloseClipboard on windows Nov 18, 2020
raphlinus
raphlinus approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Thanks for catching this!

ForLoveOfCats
ForLoveOfCats approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@ForLoveOfCats ForLoveOfCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explains the oddities I kept seeing with attempting to take screenshots of my app on Windows! I can confirm that this fixes the issue and looks reasonable. This should get an entry under "fixed" in the changelog and then it looks good to me :)

@ForLoveOfCats
Copy link
Collaborator

Dang it Raph!

@andrewhickman
Copy link
Contributor Author

Just spotted another case where this isn't always called, so don't merge just yet 😄

@andrewhickman
Copy link
Contributor Author

get_format wasn't calling CloseClipboard in the None path, so I've wrapped everything in a little helper function instead

cmyr
cmyr approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cmyr cmyr merged commit 14ad188 into linebender:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForLoveOfCats ForLoveOfCats ForLoveOfCats approved these changes

@cmyr cmyr cmyr approved these changes

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewhickman @ForLoveOfCats @raphlinus @cmyr