Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce WindowLevel, plus Mac and GTK implementations. #1231

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

rjwittams
Copy link
Collaborator

For tooltips etc. Extracted from sub-windows.

I have an example in sub-windows that uses this (via sub windows).

I also have an extremely basic druid shell example I think is unlikely to be useful going forward.

Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I think it can go in. My only nits are name/doc suggestions. Thanks!

druid-shell/src/platform/mac/window.rs Outdated Show resolved Hide resolved
pub const NSPopUpMenuWindowLevel: i32 = 101;
pub const NSScreenSaverWindowLevel: i32 = 1000;

pub fn from_window_level(window_level: WindowLevel) -> i32 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I prefer "as_raw" rather than "from" to indicate a downshift into lower level platform types, but it's a style point.

druid-shell/src/window.rs Outdated Show resolved Hide resolved
druid-shell/src/window.rs Outdated Show resolved Hide resolved
@rjwittams rjwittams merged commit a0693f9 into linebender:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants